feat: add bun built-in modules support #266
Closed
+51
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f834843 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
JounQin
requested changes
Jan 25, 2024
| @@ -117,6 +117,29 @@ let resolver: Resolver | undefined | |||
| const digestHashObject = (value: object | null | undefined) => | |||
| hashObject(value ?? {}).digest('hex') | |||
|
|
|||
| let bunCoreModules: Set<string> | undefined | |||
| const getBunCoreModules = (): Set<string> => { | |||
There was a problem hiding this comment.
It really seems hacking, can we ask @Jarred-Sumner for helping here.
Secondly, we can add a new module similar like https://www.npmjs.com/package/is-core-module.
|
Closes the PR since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bun support (so
import { Database } from 'bun:sqlite') won't triggerimport/no-unresolved.There are no existing
is-bun-modules, so a naive solution is to locatebun-typesand find alldeclare module.The PR is still in draft, as the test requires
bun-typesto be installed, which will pollute the globals.